Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2189727: external: fqdn should be persisted #497

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

parth-gr
Copy link
Member

  1. donot change rgw fqdn to ip if provided,
    As now the bucket class supports the
    entry of fqdn

  2. update crds with new description in EndpointAddress

(cherry picked from commit f66de7b)

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide).
  • Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

1) donot change rgw fqdn to ip if provided,
As now the bucket class supports the
entry of fqdn

2) update crds with new description in EndpointAddress

Signed-off-by: parth-gr <[email protected]>
(cherry picked from commit f66de7b)
Signed-off-by: parth-gr <[email protected]>
@openshift-ci
Copy link

openshift-ci bot commented Jul 10, 2023

@parth-gr: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

external: fqdn should be persisted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@parth-gr parth-gr changed the title external: fqdn should be persisted Bug 2189727: external: fqdn should be persisted Jul 10, 2023
@travisn
Copy link

travisn commented Jul 10, 2023

The BZ appears only for 4.14, if the backport is needed we will need to clone the BZ for other releases and get it approved.

@parth-gr
Copy link
Member Author

Moved it back to 4.12, as it was originally an issue opened for 4.12

And or 4.14 anyhow changes will be added

@travisn
Copy link

travisn commented Sep 28, 2023

/bugzilla refresh

@openshift-ci
Copy link

openshift-ci bot commented Sep 28, 2023

@travisn: Bugzilla bug 2189727 is in a bug group that is not in the allowed groups for this repo.
Allowed groups for this repo are:

  • qe_staff
  • redhat

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@travisn
Copy link

travisn commented Sep 28, 2023

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: parth-gr, travisn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 28, 2023
@travisn travisn merged commit 7fb8d1e into red-hat-storage:release-4.12 Sep 28, 2023
44 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants