-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2189727: external: fqdn should be persisted #497
Bug 2189727: external: fqdn should be persisted #497
Conversation
1) donot change rgw fqdn to ip if provided, As now the bucket class supports the entry of fqdn 2) update crds with new description in EndpointAddress Signed-off-by: parth-gr <[email protected]> (cherry picked from commit f66de7b) Signed-off-by: parth-gr <[email protected]>
@parth-gr: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The BZ appears only for 4.14, if the backport is needed we will need to clone the BZ for other releases and get it approved. |
Moved it back to 4.12, as it was originally an issue opened for 4.12 And or 4.14 anyhow changes will be added |
/bugzilla refresh |
@travisn: Bugzilla bug 2189727 is in a bug group that is not in the allowed groups for this repo.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: parth-gr, travisn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
donot change rgw fqdn to ip if provided,
As now the bucket class supports the
entry of fqdn
update crds with new description in EndpointAddress
(cherry picked from commit f66de7b)
Description of your changes:
Which issue is resolved by this Pull Request:
Resolves #
Checklist:
skip-ci
on the PR.